search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
224 stars 71 forks source link

Fix interface index in result.IPs #134

Closed gabidrg closed 4 years ago

gabidrg commented 4 years ago

Fixing GH-133. IPAM interface configuration is called with result.Interfaces[0] being the container interface. When IPAM configuration is finished, the result.Interfaces list is reordered and host interface is added at index 0 before the container interface, while result.IPs list of IP configuration information still points to container interface at index 0. This fixes interface index reference in IP configuration list so that chained plugins that are making use of these structures (such as sbr) will function properly.

Signed-off-by: Gabriel Dragomir gabidrg@gmail.com

kubevirt-bot commented 4 years ago

Hi @gabidrg. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
phoracek commented 4 years ago

/cc @pperiyasamy

In case you want to review changes on the IPAM code.

pperiyasamy commented 4 years ago

/lgtm

phoracek commented 4 years ago

/lgtm /approve

kubevirt-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabidrg, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/ovs-cni/blob/master/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
phoracek commented 4 years ago

/release-note-none

phoracek commented 4 years ago

Thanks for the contribution. I created a new patch release for this https://github.com/kubevirt/ovs-cni/releases/tag/v0.16.2

gabidrg commented 4 years ago

Thank you very much!