search

k8snetworkplumbingwg / ovs-cni

Open vSwitch CNI plugin
Apache License 2.0
218 stars 70 forks source link

Update ovs cni plugin to support cni version 1.0.0 #313

Closed adrianchiris closed 2 months ago

adrianchiris commented 2 months ago

This PR updates ovs cni(s) to support v1.0.0 of the spec.

Why is this needed?

sriov network operator supports the deployment of ovs-cni as well as the rendering of network-attachment-definition of "ovs secondary networks". today it does so with cniVersion 1.0.0 .

https://github.com/k8snetworkplumbingwg/sriov-network-operator?tab=readme-ov-file#ovsnetwork

kubevirt-bot commented 2 months ago

Hi @adrianchiris. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
phoracek commented 2 months ago

The containerized build is broken. I'm looking into it

phoracek commented 2 months ago

Hopefully https://github.com/k8snetworkplumbingwg/ovs-cni/pull/315 solves it

adrianchiris commented 2 months ago

The containerized build is broken. I'm looking into it

ack thx for looking into it. centos8:stream is EOL since 31.05 :\

phoracek commented 2 months ago

Go was also pretty outdated. Should be all set now. Let's see

phoracek commented 2 months ago

/release-note-none

phoracek commented 2 months ago

/test pull-e2e-ovs-cni

phoracek commented 2 months ago

@adrianchiris would you please rebase this?

phoracek commented 2 months ago

/test pull-e2e-ovs-cni

phoracek commented 2 months ago

/test pull-e2e-ovs-cni

 [2/2] STEP 1/4: FROM registry.access.redhat.com/ubi9/ubi-minimal
Trying to pull registry.access.redhat.com/ubi9/ubi-minimal:latest...
Error: creating build container: copying system image from manifest list: determining manifest MIME type for docker://registry.access.redhat.com/ubi9/ubi-minimal:latest: reading manifest sha256:adbac3083c2f340bee7cce4563665a1555901bee048bca6842b4fa0a1e6b875b in registry.access.redhat.com/ubi9/ubi-minimal: received unexpected HTTP status: 502 Bad Gateway

Another flake?

phoracek commented 2 months ago

/lgtm /approve

Thanks @adrianchiris !

SchSeba commented 2 months ago

/lgtm /approve

kubevirt-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianchiris, phoracek, SchSeba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/ovs-cni/blob/main/OWNERS)~~ [SchSeba,phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment