[software-bridges 3/x] Add bridge package

k8snetworkplumbingwg / sriov-network-operator

Operator for provisioning and configuring SR-IOV CNI plugin and device plugin

Apache License 2.0

85 stars 114 forks source link

[software-bridges 3/x] Add bridge package #691

Closed ykulazhenkov closed 4 months ago

ykulazhenkov commented 7 months ago

The package contains logic to work with managed OVS bridges.

// DiscoverBridges returns information about managed bridges on the host
DiscoverBridges() (sriovnetworkv1.Bridges, error)
// ConfigureBridge configure managed bridges for the host
ConfigureBridges(bridgesSpec sriovnetworkv1.Bridges, bridgesStatus sriovnetworkv1.Bridges) error
// DetachInterfaceFromManagedBridge detach interface from a managed bridge,
// this step is required before applying some configurations to PF, e.g. changing of eSwitch mode.
// The function detach interface from managed bridges only.
DetachInterfaceFromManagedBridge(pciAddr string) error

Context is Software bridge management feature

github-actions[bot] commented 7 months ago

Thanks for your PR, To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:
/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 9958277243

Details

648 of 856 (75.7%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.2%) to 43.08%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/host/internal/bridge/bridge.go	41	46	89.13%
pkg/host/internal/bridge/ovs/store/store.go	109	149	73.15%
pkg/host/internal/bridge/ovs/ovs.go	388	551	70.42%
<!--	Total:	648	856	75.7%	-->

Totals
Change from base Build 9955379640:	2.2%
Covered Lines:	6266
Relevant Lines:	14545

💛 - Coveralls

adrianchiris commented 6 months ago

partial review for now. added a few comments :)

github-actions[bot] commented 6 months ago

Thanks for your PR, To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:
/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

ykulazhenkov commented 6 months ago

@adrianchiris @SchSeba thanks for your reviews! I addressed your comments. PTAL

github-actions[bot] commented 6 months ago

Thanks for your PR, To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:
/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

ykulazhenkov commented 6 months ago

PR reabased. Currently it has no dependencies from other PRs

github-actions[bot] commented 5 months ago

Thanks for your PR, To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:
/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] commented 5 months ago

Thanks for your PR, To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:
/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

ykulazhenkov commented 5 months ago

The PR rebased. @SchSeba I think all comments are addressed. Can you take another look? Thanks

adrianchiris commented 4 months ago

@SchSeba can we merge this one ?

github-actions[bot] commented 4 months ago

Thanks for your PR, To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:
/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

ykulazhenkov commented 4 months ago

@zeeke Thanks for the review. I addressed your comments. Please, take another look