k8snetworkplumbingwg / sriov-network-operator

Operator for provisioning and configuring SR-IOV CNI plugin and device plugin
Apache License 2.0
85 stars 114 forks source link

Create and update SriovNetworkNodeState CRD in a single loop #701

Closed e0ne closed 3 months ago

e0ne commented 6 months ago

We don't need another 5 minutes to update SriovNetworkNodeState CRD in case if it was created.

Let's same some time between object creation and spec filling to make SR-IOV configuration more consistant and faster.

github-actions[bot] commented 6 months ago

Thanks for your PR, To run vendors CIs use one of:

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 9159964022

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/sriovnetworknodepolicy_controller.go 0 43 0.0%
<!-- Total: 0 43 0.0% -->
Files with Coverage Reduction New Missed Lines %
controllers/drain_controller.go 1 68.06%
controllers/sriovnetworknodepolicy_controller.go 1 12.04%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 9108514484: -0.02%
Covered Lines: 5114
Relevant Lines: 12802

💛 - Coveralls
adrianchiris commented 3 months ago

@e0ne is this one still relevant ?

SchSeba commented 3 months ago

Hi @e0ne should we close this one?