search

kaandedeoglu / KDCircularProgress

A circular progress view with gradients written in Swift
MIT License
1.21k stars 217 forks source link

Does the Swift 3 version work in iOS 8 and 9? #42

Closed AtheistP3ace closed 8 years ago

AtheistP3ace commented 8 years ago

Or do we need to do something special for apps that support iOS 8.4 and 9? My app uses this library but now crashes in iOS 10. If I update the library is there anything special needed to make sure it continues running on peoples devices that are running iOS 8 and 9?

kaandedeoglu commented 8 years ago

it should work with anything between iOS 8 and 10. Can you tell me more about the crash so we can figure it out?

OxenBoxen commented 8 years ago

No crash for me, using the 2.3 branch. However, I am getting XCode compile time error Failed to render and update auto layout status for UIView when I add KDCircularProgressView as a subview inside InterfaceBuilder @kaandedeoglu . Curious if you are noticing this as well. Can provide more info if needed. Running Xcode8 , Swift 2.3

AtheistP3ace commented 8 years ago

Hi sorry, I am in a tough position right now. We are on the verge of releasing our app but have not added iOS 10 support, one of the issues is this library. I tried using some of the preprocessor conditionals (#ifdef) to instantiate this library if its swift 2.2 and not if its greater but they aren't working and I'm not sure why in iOS 10. Its still erroring and I can't debug it it in iOS 10 because I'm only running Xcode 7.

Unfortunately I can't upgrade to Xcode 8 (which also means I can't use the newer swift 3 version of this library too) to test why in iOS 10 because it will force me to migrate to swift 2.3 or 3 but we are literally a few days from delivering to a client and I can't afford to make such a large change.

In phase 2 of the project I will upgrade when I have more time and delivering something with possible bugs is more allowable since we are in beginning/middle of development. So I just removed the library until then. Sorry for the long winded explanation and thanks for your quick reply.

kaandedeoglu commented 8 years ago

@OxenBoxen Can't seem to reproduce the issues you described with the 2.3 branch (trying in the example project). A sample project demonstrating the problem would be sublime!

kaandedeoglu commented 8 years ago

@AtheistP3ace Hi, I see the importance of your situation, and I'm really willing to help. Since I've already switched to Xcode 8, I can't debug Swift 2 code anymore. And I find it weird that your application which was compiled with iOS 9 SDK is crashing on iOS 10 - do you have crash logs that point to the exact location of the crash?

Also, I've tested the Swift 3 version against iOS 9.2 and it worked just fine.

kaandedeoglu commented 8 years ago

closing this due to inactivity