kaandedeoglu / KDCircularProgress

A circular progress view with gradients written in Swift
MIT License
1.21k stars 217 forks source link

Swift 4 support #80

Closed Kianoosh76 closed 5 years ago

Kianoosh76 commented 7 years ago

Hi, I've faced a problem since I upgraded my xcode. When I try to build the project, this compile error is raised.

@IBInspectable public var glowMode: KDCircularProgressGlowMode = .forward {
    didSet {
        progressLayer.glowMode = glowMode
    }
}

Property cannot be marked @IBInspectable because its type cannot be represented in Objective-C

kaandedeoglu commented 7 years ago

This is fixed on master, which is updated for Swift 4.

returnchung commented 7 years ago

Thanks! The same issue for me, and it was fixed with pulling the latest master branch and included it in my project. However, I try to implement the swift sample code and return pure black circle only. Anything wrong for me?

returnchung commented 7 years ago

Yeah...I think I'm so foolish forgetting to setup angles in the end. Anyway, it's work now.

NallapatiMalleswari commented 7 years ago

I am also facing the same problem like the gay Kianoosh was faced.But i dont know how to solve the problem .can you help me

returnchung commented 7 years ago

What I did is just git from master branch and add the main class to my project rather than cocoa pod which maybe didn’t sync the latest version yet.

Kiplol commented 7 years ago

Can confirm that the Cocoapods version of 1.5.2 still has @IBInspectable error.

NallapatiMalleswari commented 7 years ago

no , resolved .

On Wed, Oct 11, 2017 at 5:09 AM, Kiplol notifications@github.com wrote:

Can confirm that the Cocoapods version of 1.5.2 still has @IBInspectable https://github.com/ibinspectable error.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kaandedeoglu/KDCircularProgress/issues/80#issuecomment-335639010, or mute the thread https://github.com/notifications/unsubscribe-auth/AdzHXDBnaasRSlw5hreyKe6-rf5kOczAks5srAAmgaJpZM4PkPrz .

neetrath commented 7 years ago

Using KDCircularProgress (1.5.2) with Swift 4.0 still error

kaandedeoglu commented 7 years ago

Sorry for the delay. I've had problems with pushing a new Cocoapods version up. So both Carthage & Cocoapods users must point to the master branch to get the Swift 4 version.

cjlarsen commented 7 years ago

In your podfile use pod 'KDCircularProgress', :git => 'https://github.com/kaandedeoglu/KDCircularProgress' for the time being

DotoPototo commented 7 years ago

Using Cocoapods I've changed my pod file from 1.5.2 to getting the master branch as 'cjlarsen' suggests, and I've gone from the one initial error as described in this thread, to 12 saying "xxx is ambiguous for type lookup in this context"

x-hovo-x commented 6 years ago

Still same issue for me 1.5.2 Swift4.1

kaandedeoglu commented 5 years ago

Alright version 1.5.4 released on Cocoapods. Closing this one..

Sorry for the incredible delay, was going through stuff 🎈