search

kaandedeoglu / KDCircularProgress

A circular progress view with gradients written in Swift
MIT License
1.21k stars 217 forks source link

This commit gives the user more freedom when it comes to the progress… #92

Open ghost opened 6 years ago

ghost commented 6 years ago

This commit gives the user more freedom when it comes to the progress layer. They are able to set a thicker progress bar if they choose to do so. They can also manipulate a radius padding field. This allows for unique design like a progress layer outside of the circular indicator. Or with the new progress thickness size, having the progress file the entire circle.

On a separate project where we use this library, we have found these two optimizations to be very helpful.

ghost commented 6 years ago

In terms of the configurableRadius branch, I do like what that adds. My only concern is that it changes the radius variable, which will change both the track line and the progress line. It doesn't give the user the ability to edit the progress layer radius independent of the track radius (if I understood it correctly).

ghost commented 6 years ago

@kaandedeoglu Let me know if there are any more changes you want!