search

kabanero-io / collections

Kabanero Collections - This repo will be archived soon.
https://kabanero.io
Apache License 2.0
10 stars 29 forks source link

Missing timeoutSeconds in probes in stacks' app-deploy.yaml causes error when creating Knative Service #174

Closed dacleyra closed 4 years ago

dacleyra commented 4 years ago

Needs to this fix

https://github.com/appsody/stacks/issues/313

hit while using java-microprofile with //github.com/kabanero-io/collections/releases/download/0.3.0-rc.3/kabanero-index.yaml

groeges commented 4 years ago

The PRs that resolved the issues in Appsody for nodejs-loopback (https://github.com/appsody/stacks/pull/398) and nodejs-express (https://github.com/appsody/stacks/pull/403) stacks have already been picked up and included in the corresponding Kabanero collections.

If there are other collections that need similar changes we will need to wait until these have been resolved by the Appsody stack owners and then merged into the collections repository.

groeges commented 4 years ago

Although the timeoutSeconds have not been added to the Appsody stacks for java-springboot2 and java-microprofile it has been added to the kabanero collections. Will work with the Appsody team to get these changes back ported to Appsody for these stacks.

PR: https://github.com/kabanero-io/collections/pull/176

marikaj123 commented 4 years ago

@groeges - Was the issue been fixed in the collection v0.3.0-RC4 or will it be fixed in the one after?

groeges commented 4 years ago

We made changes in the Appsody java-microprofile & java-springboot2 stacks to add the timeoutSeconds element to the readinessProbe in the app-deploy.yaml to resolve the KNative Service issues. These Appsody changes have been picked up and merged into the corresponding Kabanero collections.

groeges commented 4 years ago

@marikaj123

@groeges - Was the issue been fixed in the collection v0.3.0-RC4 or will it be fixed in the one after?

No, the updates are not included in 0.3.0-rc-4 as the build was cut before the fixes went in. If necessary a new rc.X release could be cut prior to the main release or we can just do the main release.