Fix compilation for Xcode 13.3 RC

kabiroberai / node-swift

Create Node modules in Swift

MIT License

416 stars 11 forks source link

Fix compilation for Xcode 13.3 RC #2

Closed vmanot closed 2 years ago

kabiroberai commented 2 years ago

I'm inclined to merge this as a temp fix but I'm not sure how I feel about the fact that we're claiming NodeError is thread-safe when it really isn't. Does @preconcurrency import mitigate the need for this?

kabiroberai commented 2 years ago

Merging this for now since @preconcurrency doesn't always seem to cut it — though I'll def be working on improving concurrency support going forward, since NodeError isn't really Sendable. Thanks!