search

kadena-io / chainweb-mining-client

A mining client for Kadena
BSD 3-Clause "New" or "Revised" License
43 stars 11 forks source link

Add an on-demand fake miner #24

Closed edmundnoble closed 1 year ago

jwiegley commented 1 year ago

A lot of build warnings... Also, do we have any tests for this package, or is it just tested-by-use right now?

edmundnoble commented 1 year ago

it's tested by use as far as I know, and warnings are not fatal. No CI either.

larskuhtz commented 1 year ago

Test are implemented in the test folder: https://github.com/kadena-io/chainweb-mining-client/tree/master/test

Test run as part of CI here: https://github.com/kadena-io/chainweb-mining-client/blob/ae6e108ab221157198026f1a4d11976591b4e6ee/.github/workflows/build-application.yml#L65

larskuhtz commented 1 year ago

A lot of build warnings... Also, do we have any tests for this package, or is it just tested-by-use right now?

Most build warnings are about unused symbols in the stratum implementation. The reason is that parts of that implementation are still considered work in progress. I guess we could silence them with an pragma in the respective module.