search

kadirahq / mantra

Mantra - An Application Architecture for Meteor
https://kadirahq.github.io/mantra/
977 stars 51 forks source link

Babel plugin (jsx-control-statements) and imports from npm packages #95

Open tomitrescak opened 8 years ago

tomitrescak commented 8 years ago

Dears, I am trying to port my meteor-webpack project to "pure meteor", but I am running into some issues. Would you be able to help?

  1. I cannot make "jsx-control-statements" to work. It is a babel plugin that transforms "" tag to javascript. When I specify the plugin in the .babelrc such as "plugins": ["react-require", "babel-root-slash-import", "jsx-control-statements"] it does not work, the plugin is not loaded and app if throwing errors.

[EDIT] I just learned at #89 that this is not possible, since it's ecmascript package that handles the compilation. Bummer ;( Still ,what about the next point?

  1. How can I import data from npm packages? I need to import custom css from npm package in order to make it work. In webpack I just did import "sweetalert/dist/sweetalert.css" but Meteor is complaining that the package does not exists. Yet import "sweetalert is ok, but it does not import the CSS from there.

Please, any help is kindly appreciated.

adamdawkins commented 8 years ago

I just saw this after asking you about this, weird timing!

Yes, I just saw that! There's a comment in #27 from arunoda that explains the .babelrc is only for testing, so that won't help you (I found out the hard way!)

Can't help you beyond clarifying with .babelrc doesn't work for this! On Wed, 24 Feb 2016 at 00:17, Tomas Trescak notifications@github.com wrote:

Dears, I am trying to port my meteor-webpack project to "pure meteor", but I am running into some issues. Would you be able to help?

1.

I cannot make "jsx-control-statements" to work. It is a babel plugin that transforms "" tag to javascript. When I specify the plugin in the .babelrc such as "plugins": ["react-require", "babel-root-slash-import", "jsx-control-statements"] it does not work, the plugin is not loaded and app if throwing errors. 2.

How can I import data from npm packages? I need to import custom css from npm package in order to make it work. In webpack I just did import "sweetalert/dist/sweetalert.css" but Meteor is complaining that the package does not exists. Yet import "sweetalert is ok, but it does not import the CSS from there.

Please, any help is kindly appreciated.

— Reply to this email directly or view it on GitHub https://github.com/kadirahq/mantra/issues/95.

arunoda commented 8 years ago

I have also found once, I can't import individual npm modules like: import "sweetalert/dist/sweetalert.css".

But I also heard that, it's fixed in the later beta. However, I think css imports are not supported in Meteor yet. (someone could correct me, if it is)