kaegi / MorphMan

Anki plugin that reorders language cards based on the words you know
Other
260 stars 66 forks source link

Numbers should not be focus, right? #105

Open ohare93 opened 4 years ago

ohare93 commented 4 years ago

I have never seen numbers be the focus before now, and always assumed from the auto styling that they were not considered.

image

image

However that seems to be happening here. Also a time "14:30" got given the focus "14"!

image

Is this the intended functionality? I assume not, but I cannot find anything about this in the documentation. Thanks for the help.

aleksejrs commented 4 years ago

It helps you learn what "14" is in Danish.

ohare93 commented 4 years ago

Hmm, these cards also cannot be skipped with "k" to set them as AlreadyKnown. It sets the tag on the cards, but still has them at the front of the review queue for some reason.

It helps you learn what "14" is in Danish.

@aleksejrs Only the audio helps me, because my cards have that. However I already have cards which use the word for 14 "fjorten", which I have learned (and would prefer to as they are better). I know all morphs in these strange cards, and thought literal numbers were skipped as morphs as they are not highlighted as a morph by the morphman css.

aleksejrs commented 4 years ago

A use case (unseen because of a backlog): I have many generated cards with arithmetic expressions like "13×12 = 156".

ohare93 commented 4 years ago

Regardless of the potential edge case use cases of this or not, I swear this has not been the case in the past. For instance, I just came across this card:

Notice that 16 is not highlighted.

image

And you can see 16 is not in the unknown morphs:

image

Nor is it in my known morphs db:

image

I swear I did have some numbers in my known morphs db at some point in the past, after first being confused about this. But after deleting the db and rebuilding it they seem to be gone.

ohare93 commented 4 years ago

Okay, now this is getting ridiculous...

image

image

MorphMan_FocusMorph of "."! :eyes: yet only one is highlighted as well, seems like a separate issue, but related my numbers complaint, possibly.

ohare93 commented 4 years ago

The very next card...

image

image

"-" "21.30", "3?", "," and "." highlighted this time :thinking: :see_no_evil:

AtilioA commented 4 years ago

I have a lot of French cards with hours (like 2h30) and they always get targeted. It doesn't seem useful to me as for learning that sort of thing I wouldn't rely on sentence cards too much, especially ones without the hours spelled out.

A good solution would be enabling regex as user input in the Preferences menu for not targeting whatever the pattern matches. That may get slow with several thousand cards.