kafbat / helm-charts

Helm charts for kafbat projects
https://ui.charts.kafbat.io/
Apache License 2.0
7 stars 17 forks source link

CHART: add an opportunity to setup custom value for dnsPolicy #37

Open Boniker opened 2 weeks ago

Boniker commented 2 weeks ago

Issue submitter TODO list

Feature request

Hi Team,

I’d like to contribute to the Kafka-UI Helm chart but currently don’t have access to create a branch for review.

Proposed Implementation:

I’ve identified the need to make the dnsPolicy value customizable in the Deployment for Kafka-UI. The changes would look like this:

templates/deployment.yaml:

dnsPolicy: {{ .Values.dnsPolicy }}  

values.yaml:

## @param dnsPolicy for Kafka-UI pods  
## ref: https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/  
##  
dnsPolicy: "ClusterFirst" 

Additionally, I noticed some trailing spaces during local testing. While not critical, for better code quality.

Expected behavior

dnsPolicy: {{ .Values.dnsPolicy }}  

will allow users to configure the DNS policy directly through values, adding flexibility to the chart.

Your installation details

  1. commit sha: a5d34a702017539ce10300628a508120aa372f58
  2. chart version: 1.4.11
  3. config: as default, nothing special
Boniker commented 2 weeks ago

@Haarolean apologies for the confusion earlier. It's not an issue but rather a feature request. However, I couldn't find a template for creating such requests.