Feature/toolbar ui poc

[kagux]

---

This change is 

[juanperi]

Reviewed 22 of 22 files at r1. Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

web/static/css/toolbar.scss, line 28 at r1 (raw file):

    .arrow {
      transform: translate(-15px, 0);
      -webkit-transform: translate(-15px, 0);

do you really need the prefixes???

---

web/static/js/toolbar.js, line 28 at r1 (raw file):

  renderToolbar({html: html, request: request}){
    console.log("Request: ", request);
    document.body.innerHTML += '<div class="ex-debug-toolbar">' + html + '</div>';

i'll swear that doing this forces a rerender of the whole page. It could lead to unexpected results. I can see 2 workarounds:

1. We create a dom element, assign its content with innerHTML, and then append that element as the last child of body
2. In the code injector plug, we create the div with the ex-debug-toolbar class (or id). Then, here we just replace the content of that div

---

Comments from Reviewable

[kagux]

Review status: 15 of 21 files reviewed at latest revision, 2 unresolved discussions, some commit checks pending.

---

web/static/css/toolbar.scss, line 28 at r1 (raw file):

Previously, epilgrim (Juan Peri) wrote…

do you really need the prefixes???

I wasn't sure :) but you know what, it was supposed to shift popover from left border of screen, but it doesn't work anyway, I removed it. It works on live reload, because it updates css, but when js recalculates popover position, this css makes no difference :(

---

web/static/js/toolbar.js, line 28 at r1 (raw file):

Previously, epilgrim (Juan Peri) wrote…

i'll swear that doing this forces a rerender of the whole page. It could lead to unexpected results. I can see 2 workarounds: 1. We create a dom element, assign its content with innerHTML, and then append that element as the last child of body 2. In the code injector plug, we create the div with the ex-debug-toolbar class (or id). Then, here we just replace the content of that div

how about now?

---

Comments from Reviewable

[juanperi]

Awesome job!!!

---

Reviewed 6 of 6 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.

---

Comments from Reviewable

[kagux]

thanks :)