search

kai-oswald / NightOwl-VS-Theme

Night Owl Theme for Visual Studio 2019
https://marketplace.visualstudio.com/items?itemName=kaos.nightowl
25 stars 8 forks source link

Peek Definition (ALT + F12), show the wrong colors #15

Open pasqualedante opened 4 years ago

pasqualedante commented 4 years ago

Attached here a screenshot to see issue in action:

screenshot
DrThrillhouse commented 4 years ago

I think the peek definition feature does ordinarily have different styling to the main window if I'm not mistaken?

Here's a similar screenshot from the VS Dark theme: image

It has a focussed and blurred style, the focussed style is lighter than the coloring of the main window. I believe the screenshot from @pasqualedante is showing the lighter focussed style.

To @pasqualedante, is the concern that you don't like the colors being used here or that you find them offputting? Because that might be down to personal taste. If that's the case, it's easy enough to fork the project and adjust the colors to your liking - that's something I've done, as I preferred to have textboxes and comboboxes with borders, which I understand is not part of the original NightOwl aesthetic. Heh, but I like it like that, so I run my own custom version of the theme in my environment.

If you decide to do that, the XML you'll want to change this:

      <Color Name="Peek Background">
        <Background Type="CT_RAW" Source="FF002C57" />
        <Foreground Type="CT_INVALID" Source="00000000" />
      </Color>

inside the NightOwl.vstheme file - around line 1480.

DrThrillhouse commented 4 years ago

Also, if you prefer, you can just edit the value directly from VS options through Tools > Options > Environment > Fonts and Colors > (Show settings for) Text Editor > (Display items) Peek Background:

image