search

kai-oswald / NightOwl-VS-Theme

Night Owl Theme for Visual Studio 2019
https://marketplace.visualstudio.com/items?itemName=kaos.nightowl
25 stars 8 forks source link

ReSharper support and additional controls #22

Open DrThrillhouse opened 4 years ago

DrThrillhouse commented 4 years ago

Hi @kai-oswald

I've been experimenting with a few more controls and wanted to gauge your interest in merging some of my changes. I haven't created a pull request yet because I'm doing it in a custom branch where I've added a couple of usability tweaks for myself that aren't really on-brand for the NightOwl theme. But if you're interested, I'll weed out my customisations and provide you with only the new "on-brand" controls I've styled.

Branch here: https://github.com/DrThrillhouse/NightOwl-VS-Theme/tree/custom

You'll find everything uses correct NightOwl colors. Some of them have been chosen manually, but I've also written a quick and dirty console app/tool to map colors from the default VS Dark theme into NightOwl which I've found works surprisingly well! I haven't created a repo for the tool yet - most particularly because it is very ugly and manual in terms of settings! But it may help in styling future controls.

Anyway, see what you think image

DrThrillhouse commented 4 years ago

I also ask because I'm not sure how much the ReSharper theme categories differ between versions of ReSharper. I'm aware of at least one variation, because I was trying to style those parameter name hints (the ones with the arrows pointing to them in the previous post) and it turns out I was using their old name, which is why they weren't working for me in the new version. So yeah, not sure how much ongoing maintenance that would open the project up to.

kai-oswald commented 4 years ago

Hey @DrThrillhouse I don't use ReSharper myself, so I'd leave the customization up to you (Screenshoots look clean!). As far as I've seen, the ReSharper elements have its own elements, so this won't have an effect for people not using ReSharper.

I'd suggest you just create a PR and stick as close to the Night Owl colors as you can.

As for the tool you mentioned, I actually wanted to create something similiar, where you can quickly adjust the colors to your likings. Then just perform a "search and replace" to create a new theme. If you get something open-sourced, I'd definitely be interested!