search

kai-oswald / NightOwl-VS-Theme

Night Owl Theme for Visual Studio 2019
https://marketplace.visualstudio.com/items?itemName=kaos.nightowl
25 stars 8 forks source link

Hard to see text is selected when editing XML #25

Closed DrThrillhouse closed 4 years ago

DrThrillhouse commented 4 years ago

The selected text color when editing XML is noticeably darker than it is when editing other types of file such as C#, and it seems to have a thick border consisting of the normal, lighter selection color. It makes it difficult to pick out selected text at a glance:

image

DrThrillhouse commented 4 years ago

I do have a fix for this already, it looks like the XML and XSLT colors under the Text Editor Language Service Items category have been given an explicit background colour, for example:

      <Color Name="XML Attribute Quotes">
        <Background Type="CT_RAW" Source="FF011627" />
        <Foreground Type="CT_RAW" Source="FF5D96AC" />
      </Color>

This looks normal when no text is selected, but results in the artefacts you see with selected text. Just removing that <Background> tag from each of those Color blocks is enough to fix the issue.

Raising this as an issue so that the product owner @kai-oswald can evaluate whether or not this should be fixed and to provide a reference for the upcoming PR.