search

kaicataldo / material.vim

🎨 A port of the Material color scheme for Vim/Neovim
MIT License
610 stars 71 forks source link

Add initial MaxMEllon/vim-jsx-pretty styles #35

Closed garand closed 5 years ago

garand commented 5 years ago

This adds support for HTML attributes in JSX to display as italic. There may be other JSX changes to make as well, so this can be used as a starting point, or merged as is if you're interested. Thanks for an awesome theme!

image
kaicataldo commented 5 years ago

Hey there! Thanks for the kind words :) That's actually the intended behavior (and what I'm seeing locally):

Screen Shot 2019-11-14 at 2 18 39 AM

I'm certainly not opposed to merging this, but it seems like we should actually add all the special tags that vim-jsx-pretty adds!

garand commented 5 years ago

Interesting... not sure why I'm not seeing that.

kaicataldo commented 5 years ago

I’m not using the vim-jsx-pretty plugin, and it looks like it registers a number of its own custom syntax. I would be happy to support it, but I do think we should try to support all the relevant tags, instead of just one!

One other possibility is to see if vim-jsx-pretty can make changes upstream to inherit styles from another defined syntax.

kaicataldo commented 5 years ago

You can see in the differences between our screenshots that the highlighting for other syntax doesn’t match either (though if we add styles for this plugin we might be able to target syntax that we can’t currently and make things look even prettier 😃).

I’ll try to take a look at this soon and see if I can implement it.

kaicataldo commented 5 years ago

Sorry for the delay here - I looked into this, and I think it makes sense to just set the jsxAttrib syntax styles to begin with. Thanks for contributing!

garand commented 5 years ago

You're welcome! I'll keep an eye out for any other oddities and see if they warrant inclusion. Great work on the theme. 👍

kaicataldo commented 5 years ago

Thanks for the kind words. PRs welcome!