kaiiyer / webtech

Identify the technologies used on websites. (Dig-deep into web tech from your terminal)
GNU Lesser General Public License v3.0
48 stars 39 forks source link

test.yml created to test code for every push #51

Closed keshakaneria closed 4 years ago

keshakaneria commented 4 years ago

test.yml tests the code when pushed to solve the errors and bugs issue #45

keshakaneria commented 4 years ago

above files were committed for PR #43 @kaiiyer @utkarsh-raj

keshakaneria commented 4 years ago

will nmp install help here?

on: [push]

jobs:
  test:
    name: Test on node ${{ matrix.node }} and ${{ matrix.os }}

    runs-on: ${{ matrix.os }}

    strategy:
      matrix:
        node: [8, 10, 12]
        os: [ubuntu-latest, macOS-latest, windows-latest]

    steps:
      - uses: actions/checkout@v1
      - name: Use node ${{ matrix.node }}
        uses: actions/setup-node@v1
        with:
          node-version: ${{ matrix.node }}
          registry-url: https://registry.npmjs.org
      - name: install
        run: npm install
      - name: lint
        run: npm run lint
      - name: build
        run: npm run build
      - name: test
        run: npm test

writing this and adding

name: python-lint
uses: CyberZHG/github-action-python-lint@0.0.2
keshakaneria commented 4 years ago

or directly add this workflow of python-lint?

workflow "Python Lint" {
  on = "push"
  resolves = ["python-lint"]
}

action "python-lint" {
  uses = "CyberZHG@github-action-python-lint@master"
}
kaiiyer commented 4 years ago

Directly add the python lint one to test.yml

kaiiyer commented 4 years ago

image error shown

Remove the - before name

keshakaneria commented 4 years ago

image still uses isnt identified

kaiiyer commented 4 years ago

image still uses isnt identified

Check the indentation !

keshakaneria commented 4 years ago

Gave 1 tab indentation but isnt working. Also tried with 1 space. I tried the same code on online yaml validator. It is showing valid there but not here in github editor image

kaiiyer commented 4 years ago

The intendation of "uses" is what I'm talking about.

keshakaneria commented 4 years ago

Still no actions the workflow is performing is visible. Code seems to have no indentation problem checked in Yaml formatting sites online too and indentations of "uses" also seems to be good but github editor shows different than online sites so didnt change in "uses" and committed the file image

kaiiyer commented 4 years ago

I'll fix the it and close the issue !

keshakaneria commented 4 years ago

Will it be counted as my successful PR? because along with this PR #43 is also connected of my PR

kaiiyer commented 4 years ago

Will it be counted as my successful PR? because along with this PR #43 is also connected of my PR

Yeah it's a succesfull PR