International format numbers via People icon

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Setup cSip for outgoing calls
2. Tap the little "people" icon at the top right
3. Select a contact
4. Select the number "+1 123 456 7890" 
5. Tap OK
6. Select CSip account (not mobile)

What is the expected output? What do you see instead?

Expected: Call would go through

Got: "SIP URL is invalid for call"

Please use labels and text to provide additional information.

All of my numbers are in international format "+1 123 456 7890" in my Contacts. 
If I initiate a call through the regular Phone app, with CSip Dialer 
Integration active, I can select my SIP account from there and the call will go 
through. This is specific to using the contacts access within CSipSimple.

Original issue reported on code.google.com by dc3de...@gmail.com on 28 Nov 2010 at 7:04

[GoogleCodeExporter]

Oh, 0.00-15-16 version

Original comment by dc3de...@gmail.com on 28 Nov 2010 at 7:05

[GoogleCodeExporter]

Ok, I'm rewriting this part of the integration. Will probably be better soon. 
This integration was just a first try (and actually seems to not work at all 
for some devices that doesn't properly implement contact intent receivers).

Original comment by r3gis...@gmail.com on 28 Nov 2010 at 10:12

• Changed state: Accepted

[GoogleCodeExporter]

I'm amazed at your energy! Thanks.

Original comment by dc3de...@gmail.com on 28 Nov 2010 at 10:38

[GoogleCodeExporter]

Found and fixed (r503). The numbers coming from the phonebook have spaces in 
them, for example +1 123 456 7890. This fails in pjsua.verify_sip_url(). In 
PjSipService.sanitizeSipUri() I added a check for numbers with or without sip: 
and with or without leading '+' followed by only numbers or spaces. Only if 
those conditions are met, the spaces are removed from 'callee'. Now I can call 
from my phonebook :-)

Original comment by dc3de...@gmail.com on 25 Dec 2010 at 1:28

• Changed state: Started

[GoogleCodeExporter]

Original comment by dc3de...@gmail.com on 25 Dec 2010 at 1:32

• Changed state: Fixed

[GoogleCodeExporter]

See my comment on r503

Original comment by r3gis...@gmail.com on 25 Dec 2010 at 7:55

• Changed state: Accepted

[GoogleCodeExporter]

I have added comments to r503. I will remove the change if you wish after 
reading my comments.

Original comment by dc3de...@gmail.com on 25 Dec 2010 at 4:42

[GoogleCodeExporter]

I see it has already been removed. I'll continue in comments to r505.

Original comment by dc3de...@gmail.com on 25 Dec 2010 at 5:36

[GoogleCodeExporter]

Fixed (hopefully the right way!) in r506. Needed same phone number processing 
as added in r505, but in activity result for pickup-contact button on home 
screen.

Original comment by dc3de...@gmail.com on 25 Dec 2010 at 7:59

• Changed state: Fixed

[GoogleCodeExporter]

Yes excellent ;).
sorry for my punctilious approach. But I've in mind the new sip 2.3 integration 
those days.
As your fix is really interesting for the entire app and not just the pjsip 
stack, it has to be done on the right place :).

Besides pointing out this issue is really interesting cause there is still the 
filters that does not apply. I missed that too.
So I'll open an issue for that (cause I'll also add a note about integration of 
emails+ skype im accounts).

Original comment by r3gis...@gmail.com on 25 Dec 2010 at 8:35

[GoogleCodeExporter]

For reference, issue 539 for next steps for contact integration within 
CSipSimple. Do not hesitate to enrich it if you have some ideas on that ;) 

Original comment by r3gis...@gmail.com on 25 Dec 2010 at 8:45

[GoogleCodeExporter]

Issue 547 has been merged into this issue.

Original comment by dc3de...@gmail.com on 27 Dec 2010 at 9:44