kairos-io / kairos

:penguin: The immutable Linux meta-distribution for edge Kubernetes.
https://kairos.io
Apache License 2.0
1.09k stars 96 forks source link

:sparkles: agent: subcommand to edit grub options #154

Open mudler opened 2 years ago

mudler commented 2 years ago

Is your feature request related to a problem? Please describe. Editing grub options is easy during bootstrap, but requires few steps in the way to do that after the system is deployed

Describe the solution you'd like A subcommand in the agent that lets the user edit the grub options, an example could be:

$ kairos-agent edit grub-options "key" "value"

Describe alternatives you've considered N/A

Additional context

The code to set grub option is already existing, needs just to be properly exposed via CLI

Itxaka commented 5 months ago

is this still needed @mudler ? a commadn to set grub values to keys already ships with grub, we should not reinvent that, and we now have exposed the next entry chooser in the agent. I feel like this could be easily closed?

mudler commented 5 months ago

is this still needed @mudler ? a commadn to set grub values to keys already ships with grub, we should not reinvent that, and we now have exposed the next entry chooser in the agent. I feel like this could be easily closed?

the issue here is that we cannot relay on grub commands because, as an user that wishes to change that it is not really straightforward:

The motivation behind this is, basically, just UX enhancement - also a wrapper around the grub commands would help out as the user shouldn't need to know how we configure the system to let edit the grub options