search

kaivi / ReactInlineEdit

Simple React component for in-place text editing and validation
MIT License
170 stars 90 forks source link

replace react proptypes #41

Closed chukitow closed 5 years ago

chukitow commented 7 years ago

Implementing type checking with proptypes instead of React.proptypes https://reactjs.org/docs/typechecking-with-proptypes.html

gesmith commented 6 years ago

@kaivi Can we please get this merged? The package is breaking while using newer versions of React (v16.2).

epicfaace commented 6 years ago

@kaivi ?

AlexisWilke commented 6 years ago

I tested this pull (#41) and it works great for me. Everything is as expected and no problems with the props.

I created my own version so I can use it in my project, cleanly. It's here:

https://www.npmjs.com/package/react-edit-inline2

And on GitHub, I have a fork here:

https://github.com/AlexisWilke/ReactInlineEdit

I do not intend to support my fork, but it could be a better starting point for your own in case you like this inline edit widget. Note that at this time there are 81 forks, so there are possibly others of interest.