Open DanilYachmenev opened 1 year ago
Solution 1 Abstract: Read the doc could create online documentation from Sphinx project in Github. Here is an example of what it looks like. (source link) Steps:
.readthedocs.yaml
in base folder that customize the building process. (This step is optional until September 2023 but recommend)Pro:
Is there any step that I should further describe in proposal?
Does the outcome proposal Gdoc have to be formal?
Does the outcome proposal Gdoc have to be formal?
no need to be formal in words but be structured and straight to the point it should be something that we can work together on afterwards (like extending, discussing points etc)
Solution 2 Abstract: Mkdoc is a static site generator where file are written in markdown and configured with one YAML configuration file. (source link) Step:
pip install mkdocs
and create project with mkdocs new my-project
mkdocs.yml
, and a folder named docs
where place all documentation source files.mkdocs build
mkdocs gh-deploy
Pro: Provides more extensive customization options than RTD
How to make Mkdoc searchable without third part tool: https://github.com/squidfunk/mkdocs-material/blob/master/docs/setup/setting-up-site-search.md# https://squidfunk.github.io/mkdocs-material/setup/setting-up-site-search/
Examples: https://mkdocs-macros-plugin.readthedocs.io/en/latest/pages/
Do I need to create a PR for the proposal gdoc?
Do I need to create a PR for the proposal gdoc?
No need yet IMO lets discuss everything here until there is anything to commit to the codebase
You can make a PR if you may need to do some code changes to demonstrate smth
Okay. So far I feel like Mkdoc is a more straightforward and lucid solution to me since RTD requires to build a Sphinx project first. I am still searching around for the difference between RTD and Mkdoc but I don't think there will be any huge difference on the final product besides customization. For searchable functionality, RTD has built-in search function, and I also find some open-source tutorials about setting up site search for Mkdoc using third party plugins.
@zli00185 well a Gdoc with your findings would've done a good help, just post a link here in the issue so we have a doc that is easy to work on
also extrapolate on GP questions for Sphinx as well so we could compare fully
nice!
For now I'm more for Mkdoc since it is
Although 1 question: 1 of the mentioned RTD pros is automatic documentation update is it also available by Mkdoc?
nice!
For now I'm more for Mkdoc since it is
- more customisable
- more straightforward to implement
Although 1 question: 1 of the mentioned RTD pros is automatic documentation update is it also available by Mkdoc?
Just confirm it is also available in Mkdocs.
@zli00185 tbh for me it is still hard to comprehend how the final form will look like without a draft example Let's start from a prototype for Mkdoc
Implement the described steps, get a link to the formatted documentation and show the final look File a PR from a new branch if needed
I build a prototype with two md files from sorrentum docs folders on my Github repository and it should be available online now. I didn't add any configuration so it is all in default setting. So far the searching functionality is workable, but I am still figuring out why the image is not showing. @DanilYachmenev Should I further improve the layout and theme of the current prototype?
@zli00185, nice one! I could access the website
couple moments:
index.md
file and put a README there instead?
After done, lets also build the same size prototype for RTD so we can compare
lets deal with screenshots display, it is important
Image display issue is fixed. We need to change the image display code in md file. For example, <img src="Buildmeister_process_figs/image1.png" style="width:3.40625in;height:1.82292in" />
need to be ![Alt Text](Buildmeister_process_figs/image1.png)
(Just suggest, this might be a good warm-up issue)
I updated the md file in the Github repository and online docs should be updated too.
@zli00185
can we remove default index.md file and put a README there instead?
- also pls check if we can control the order of displayed documentation on the generated website and if ref links are working
I am pretty sure index.md could be replaced or modified, and the order of each md files could be changed in configuration file
Check if doc updates are being pulled to the website automatically. If not, describe the process on how to pull the changes in docs to the website
Just confirm it with the image code update. It will automatically update the library after git push
.
Just confirm it with the image code update. It will automatically update the library after
git push
.
do it in your repo/PR and confirm that it is necessary we will do it if we decide to go with Mkdocs for now we need to get a good looking example that will demo that it displays docs correctly
- I do not see screenshots in the prototype website though, could you add some docs with it there?
The Buildmeister process page contain screenshot at Notification system section. It should be visible now.
@zli00185 how's the progress with RTD?
@zli00185 how's the progress with RTD?
I could probably upload the RTD library in two days. But before that I am still trying to figure out changing the theme for Mkdocs. There is a more popular theme called Material but I currently have some issue activate it. If we don't have to worry about theme at this point I could move on to build RTD.
@zli00185 do not spend too much time on some actions if they are not crucial and take more than ~1 hour if nothing is found them its OK, just mention it in the report message
the higher priority is to see both sources and then we can decide if we need additional research to choose one of them
Here is a prototype for RTD without sorrentum docs. Current issues:
I am still searching for workable solutions for either issue.
Here is a prototype for RTD without sorrentum docs. Current issues:
- RTD doesn't support markdown file, and I encounter issue activate extension for markdown.
- After convert md file to rst file, the server could not recognize the page after rebuilding.
I am still searching for workable solutions for either issue.
So RTD requires everything to be converted in their own format? If so, lets try to find a way to convert md files to the desired format however, it should be easy and native
spend no more than 1 hour on dealing with RTD and switch back to Mkdocs customization If we can make code blocks more visible IMO no need to spend more time on RTD
All previous issues solved. Here is the final prototype for RTD from my Github repository. One thing about RTD I find usefull is it allow us to create different version of the library base on PR.
@zli00185 nice! I personally like RTD more it is also in-line with documentation for other projects that I've seen
Is it much more complicated to implement than Mkdocs? You mentioned some problems with RTD implementation so I want to understand how crucial they are
Could you pls update Gdoc with links to prototypes and update info about pros and cons
Could you pls update Gdoc with links to prototypes and update info about pros and cons
Gdoc updated
Is it much more complicated to implement than Mkdocs?
It actually is not difficuilt at all. The tuteriol of extension for Mkdown file does not mention putting the extension into requirenment.txt file (which is a simple but crucial step) and that is why it kept failing on servicer. Once I figure that out, it is as straightforward as using Mkdocs.
@zli00185, good job! pls take a look at questions I left at Gdoc so we make the last clarifications before making a proposal about the better option
Now we need to choose 1 among the 2 options tested by @zli00185 and continue moving documentation there.
Both options have document browsing feature and quite nice visual interface. Below you can find prototypes and distinctive pros and cons (if 1 is present in 1 option in means that another does not have it):
1. Read the Docs (RTD)
Pros:
Cons
2. Mkdocs
Pros:
You can see full report and discussion in Gdoc
So in short, RTD would be much easier to update, while Mkdocs will be much nicer to use. My pick is Mkdocs - all for the final user even if it means a bit more pain for us.
WDYT @gpsaggese?
@gpsaggese could you ptal at the message above so we can proceed?
Can we move the gdoc https://docs.google.com/document/d/1lOS9s88WdXnjbv5pm0C7ZXqacvfnAWu0Yum_jRLF_lQ/edit to a dir corresponding to the bug in https://drive.google.com/drive/u/1/folders/1LXwKpmaFWJI-887IoA50sVC8-dw_1L8I? You might need to copy / paste since once the file is created in a different account is difficult
Adding @jsmerix since this is part of the push towards better documentation.
Nicely done @zli00185
Questions:
Can we move the gdoc https://docs.google.com/document/d/1lOS9s88WdXnjbv5pm0C7ZXqacvfnAWu0Yum_jRLF_lQ/edit to a dir corresponding to the bug in https://drive.google.com/drive/u/1/folders/1LXwKpmaFWJI-887IoA50sVC8-dw_1L8I? You might need to copy / paste since once the file is created in a different account is difficult
https://drive.google.com/drive/folders/1Ch2XyqWKAdj8wc-MolGxK-cWYwgwN9y8?usp=drive_link
Thx. Also can we convert to Google doc instead of sh*tty Word and remove the Micro$oft junk.
- What are the advantages wrt to going to https://github.com/cryptokaizen/cmamp/tree/master/docs?
The ones you've mentioned are the most important ones.
Apart from them both tools:
- Can we publish this under GitHub?
Yes, and the changes can be pulled automatically afaik
Here is a big but important one, believe in you @zli00185 Ask questions in the issue if anything is unclear
Goal: We would like to make it easier to browse / search the documentation in docs For now, we just go https://github.com/sorrentum/sorrentum/tree/master/docs and browse, or
grep
with bashWe would like to publish the docs with something fancier, something like:
GitHub supports automatically publishing things with https://docs.github.com/en/enterprise-server@3.6/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site
To make searching easy we could use https://www.algolia.com/
The outcome should be a project proposal Gdoc with some ideas
FYI @gpsaggese @samarth9008 @jsmerix