search

kaizendorks / pymongo_inmemory

A mongo mocking library with an ephemeral MongoDB running in memory.
MIT License
40 stars 13 forks source link

[Question] the downloader of the mongo version in the new realiaze is realy necessary? #44

Closed leonardoleanodev closed 1 year ago

leonardoleanodev commented 3 years ago

It is a good practice to download into the init some packages to make the libary work it sould not be bether to put it into the all package? Why did you (@ekarademir) put that into the init?

ekarademir commented 3 years ago

The downloader has been refactored recently, previously it was just a file, and now it's a module. I had to refactor other parts into some decent shape and simply didn't have time to refactor everything. It looks strange but the reason is, basically, historic.

ekarademir commented 1 year ago

I think the question is answered. At this point I think module level implementation has some merits.