search

kaj / rust-pdf

Generating PDF files in pure Rust
144 stars 13 forks source link

Support for ZapfDingbats encoding and fix for text example #4

Closed hummingly closed 6 years ago

hummingly commented 6 years ago

This adds support for the encoding of the ZapfDingbats font. Additionally, a small change in the write_object method for FontSourcemakes the text example conform to the PDF 1.7 standard. The entry Encoding for the Symbol shouldn't be the name of the encoding itself but the base encoding WinAnsiEncoding(or MacRomanEncoding or MacExpertEncoding).

hummingly commented 6 years ago

Every commit before Adds ZapfDingbats encoding should be ignored because all changes until then have been moved to another branch.

kaj commented 6 years ago

Hi @hummingly , thank you for your contribution!

I'm afraid the code was in a rather sorry state before your suggested changes, with the code untouched for more than a year builds failing. I have now fixed the most glaring problems, and the builds for the master branch passes.

Could you consider rebasing your changes (as well as maybe getting rid of the commits that should be ignored from this branch)?

Thank you again for your contribution!