search

kakao / s2graph

This code base is retained for historical interest only, please visit Apache Incubator Repo for latest one
https://github.com/apache/incubator-s2graph
Other
250 stars 32 forks source link

Seperate mutation on storage from Edge to Graph. #145

Closed SteamShon closed 8 years ago

SteamShon commented 8 years ago

currently, Edge contains mutate method which is responsible to communicate with HBase.

logically, it would be much better to make edge responsible for building RPC request(not actually fire RPCs to HBase.

SteamShon commented 8 years ago

For the first step, I moved mutate on Edge class into Graph.

SteamShon commented 8 years ago

I think it is good start for abstracting storage backend specific codes away from core components(Edge,Vertex), so we can later try with other key/value storage options.

Also this can be good start for implementing TinkerPop3.

I will open new two issue. one for abstracting away storage backend and other for implementing TinkerPop3.