search

kakounedotcom / connect.kak

Connect a program to Kakoune clients
https://kakoune.org
The Unlicense
88 stars 18 forks source link

Suggested changes #16

Closed xxxserxxx closed 4 years ago

xxxserxxx commented 4 years ago

focus indeed works with both the window manager and tmux, so I removed the logic that switched on the environment; it's controlled now only by the user setting and the work is done by focus.

The get trick works well, so I removed all of the hacking around to get at the option and used that directly.

The difference from master now boils down to the fact that the default behavior is the same as pre-patch (focus is disabled by default), but can be enabled by the user setting an option. Again, the use case I see for this is per-buffer-type configuration.

alexherbo2 commented 4 years ago

Can you rebase to master, so I can clearly see the changes?

alexherbo2 commented 4 years ago

I prefer to not have an option for such behavior if possible.

When we click a file without connect, the window manager or desktop environment give the focus to the newly created window.