search

kaliber-scala / play-s3

S3 module for Play
MIT License
119 stars 49 forks source link

Prefixed credentials #50

Closed EdgeCaseBerg closed 9 years ago

EdgeCaseBerg commented 9 years ago

As originally discussed here

Ability to use multiple credentials in a single application easily.

I can add examples to the README file, but wanted to get feedback on the implementation itself first.

EECOLOR commented 9 years ago

Yesterday I have worked on the 6.0.0 branch and force pushed it. So it might be a good idea to rebase on that. If you don't know how that works it's fine. As soon as I am able to spend more time I will integrate this change.

EdgeCaseBerg commented 9 years ago

I've pulled down your force-pushed 6.0.0 branch. Saved my old branch to a different name, branched off of the new 6.0.0 branch, and cherry picked the commits with the prefix credentials feature. Then force pushed my own prefixed-credentials branch so that it shares the common base with your new 6.0.0.

EECOLOR commented 9 years ago

Awesome.

EECOLOR commented 9 years ago

I have intergrated your commits in the 6.0.0 version