kalkih / mini-graph-card

Minimalistic graph card for Home Assistant Lovelace UI
MIT License
3.06k stars 237 forks source link

Removing dead space #1143

Closed Nickduino closed 1 month ago

Nickduino commented 1 month ago

I highlighted in red the dead space between the header and the value and between the value and the graph on the sensor card and the mini-graph-card:

image

I couldn't find a parameter to reduce it, did I miss it or is it inexistant? Would it be possible to add it (the cherry on the cake would be to allow us a negative value).

Since an image is worth a 1000 words, my dream card (for a dense dashboard on mobile) would be:

image

You can see in blue the bottom of the text is below the top of the graph (which I don't mind since if it was over the graph, it would be over historic values and not the recent ones I'm mostly interested in) : image

ildar170975 commented 1 month ago

Suggest you to ask in the main mini-graph-card thread in Community. This is possible by card-mod. https://community.home-assistant.io/t/lovelace-mini-graph-card/71385/

ildar170975 commented 1 month ago

Closing since this is a question related to customizing by card-mod.

Nickduino commented 1 month ago

this is a question related to customizing by card-mod.

It's not, it's a FR. I wish I didn't have to use card-mod, it's extremely daunting for a new user and it's not as future proof as a feature that is supported by the card's developer.

The options of the mini-graph-card allow us to hide the header, why not set up the dead space? It's the whole point of a mini graph: to be mini :-)

ildar170975 commented 1 month ago

I see your point. You wish to use ONE custom plugin, not several. In real applications, there are custom cards which using features of other custom cards - and nobody bothers about these dependencies.

There are some other thoughts here: You are proposing to manage spaces between elements. Almost none of custom/stock cards allow similar alterations. Take a stock Entities card: you cannot manage a vertical spacing between rows, a height of a title etc. These alterations are usually done by card-mod. Also, a user John wants to manage spaces, a user Jane wants to manage background etc. Providing native options for all the endless CSS alterations will drastically increase a complexity of this card. It will not be “mini” in this case )))

Nickduino commented 1 month ago

Dependencies are different because the developer supports it and will make sure a change in a dependency won't break his card while you can't check every customization done with the custom card.

Almost none of custom/stock cards allow similar alterations. Take a stock Entities card: you cannot manage a vertical spacing between rows, a height of a title etc. These alterations are usually done by card-mod. Also, a user John wants to manage spaces, a user Jane wants to manage background etc. Providing native options for all the endless CSS alterations will drastically increase a complexity of this card. It will not be “mini” in this case )))

You're right. The truth is I don't necessarily think the dead space should be customizable (although it would be nice). But I think it's way too big currently, especially for a card that says mini in its name ;-)

My use case is building graphs that fit in a 2*2 grid, so not big but not minuscule either. Here is a side-by-side of HA's default graph: line and your [mini-graph-card](https://github.com/kalkih/mini-graph-card). For the [mini-graph-card](https://github.com/kalkih/mini-graph-card), I matched the state size to the graph: line and reduced the height of the graph until it matched the total height of the graph: line:

image

I love the ability to use dynamic colors and multiple entities of your card but you can see the graph doesn't show nearly as much information (It's the same data but the scales "hides" information) in my use case.

I counted the pixels and your dead space is about double the one from graph: line:

image

Could you consider matching it or getting close? Or possibly make it dynamic to the size of the card (or the size of the state, like 75% of the height of the state)?

ildar170975 commented 1 month ago

Or possibly make it dynamic to the size of the card (or the size of the state, like 75% of the height of the state)?

suggest you to create a FR for this with a detailed algorithm.