kallerosenbaum / grokkingbitcoin

Source repository for Grokking Bitcoin
https://www.manning.com/books/grokking-bitcoin
Other
258 stars 54 forks source link

Fixed Image Display Issues in .adoc Files for Chapters 01-11 #35

Open virtualvasu opened 5 months ago

virtualvasu commented 5 months ago

This pull request fixes the issue where images were not being displayed in the .adoc files for chapters 01 through 11.

Changes:

Testing

Additional Notes

kallerosenbaum commented 4 months ago

Thanks for the PR. I haven't put any effort in making the book readable directly on github, because there are typesetting, formulas, etc that aren't possible to render on github, only through building it properly using asciidoctor in accordance with the instructions in the readme. The book is available for readers in its full glory on https://rosenbaum.se/book/

Your PR is a strict improvement in terms of readability on github, but since a lot of other stuff isn't displayed correctly anyway, I'm hesitant to merge it. As an example of issues that are still not solved:

image

I'm not sure these issues are solvable, as github's asciidoc rendering isn't compatible with all asciidoctor features.