error when compiling - redefinition of xBuf

kallisti5 / huexpress

A PCEngine emulator forked from Hu-Go!

Other

28 stars 4 forks source link

error when compiling - redefinition of xBuf #18

Open Strugglemeat opened 1 year ago

Strugglemeat commented 1 year ago

when compiling:

/usr/bin/ld: src/osd_sdl_gfx.o:/huexpress-git/src/huexpress-git/src/osd_sdl_gfx.c:26: multiple definition of `XBuf'; src/osd_sdl_machine.o:/huexpress-git/src/huexpress-git/src/osd_sdl_machine.c:13: first defined here collect2: error: ld returned 1 exit status

I was able to get the emulator to compile by modifying one of the definitions of XBuf to

extern uchar* XBuf;

rofl0r commented 1 year ago

that's probably due to gcc 10+ defaulting to -fno-common. why don't you open a PR with your change ? it seems correct.