kaltura / nginx-kafka-log-module

Send Kafka messages from Nginx
BSD 2-Clause "Simplified" License
65 stars 22 forks source link

nginx-plus 1.13.4 compile errors #5

Open joshgibs opened 7 years ago

joshgibs commented 7 years ago

Hi,

Thanks for the module!

I'm trying to compile the module for nginx-plus 1.13.4 and I get the following errors:

$ make modules /Applications/Xcode.app/Contents/Developer/usr/bin/make -f objs/Makefile modules cc -c -fPIC -pipe -O -Wall -Wextra -Wpointer-arith -Wconditional-uninitialized -Wno-unused-parameter -Wno-deprecated-declarations -Werror -g -I src/core -I src/event -I src/event/modules -I src/os/unix -I objs -I src/http -I src/http/modules \ -o objs/addon/nginx-kafka-log-module/ngx_http_kafka_log_module.o \ ../nginx-kafka-log-module//ngx_http_kafka_log_module.c ../nginx-kafka-log-module//ngx_http_kafka_log_module.c:235:5: error: use of undeclared identifier 'rd_kafka_topic_t' rd_kafka_topic_t rkt; ^ ../nginx-kafka-log-module//ngx_http_kafka_log_module.c:235:42: error: use of undeclared identifier 'rkt' rd_kafka_topic_t rkt; ^ 2 errors generated. make[1]: [objs/addon/nginx-kafka-log-module/ngx_http_kafka_log_module.o] Error 1 make: [modules] Error 2

erankor commented 7 years ago

Looks like librdkafka was not identified during configure, most references to librdkafka are wrapped with #if (NGX_HAVE_LIBRDKAFKA) while this one is not. While it is possible (and probably makes sense) to fix it, I don't think this module has any value without librdkafka :) you need make sure it's installed, and that its headers are in the compiler search path.

joshgibs commented 7 years ago

Thank you erankor! I was able to get the module compiled now, but it still has an error when starting nginx. I have a feeling you're on to something where the headers are not in the search path.

nginx: [emerg] dlopen() "/etc/nginx/modules/ngx_http_kafka_log_module.so" failed (/etc/nginx/modules/ngx_http_kafka_log_module.so: undefined symbol: rd_kafka_set_log_level) in /etc/nginx/nginx.conf

erankor commented 7 years ago

I see you are compiling it dynamically, the config file wasn't fully ready for that... please try this pull - https://github.com/kaltura/nginx-kafka-log-module/pull/6

NaturalL commented 4 years ago

In my case

git clone https://github.com/edenhill/librdkafka cd librdkafka ./configure make sudo make install

erankor commented 4 years ago

@NaturalL, I didn't understand what error you are getting