search

kalys / bamboo_ses

AWS SES adapter for Bamboo
MIT License
35 stars 24 forks source link

Poison is hardcoded #39

Closed kreba closed 3 years ago

kreba commented 3 years ago

ExAws.SES.format_template_data/1 uses the Poison library to encode JSON.

In our project we don't have the Poison library installed. We prefer to use Jason instead.

Bamboo makes the choice of JSON library configurable. The configured value is accessible through Bamboo.json_library/0.

What do you think about using Bamboo's configured JSON library instead of hardcoding Poison? I'd be happy to provide a PR.

kreba commented 3 years ago

Sorry, this was a mistake. The referenced code is not part of this repository :see_no_evil:

This issue should have been opened in ex_aws_ses instead. And in fact it has: ex_aws_ses#9