search

kalys / bamboo_ses

AWS SES adapter for Bamboo
MIT License
35 stars 24 forks source link

Feature/tag upgrade #46

Closed jarrodmoldrich closed 2 years ago

jarrodmoldrich commented 3 years ago

Hi @kalys ,

I needed the ability to add tags to an email, and it seems this feature is available upstream on :ex_aws_ses. To use the feature required extracting :tags from the private dictionary contained in Bamboo.Email, and then passing it to :ex_aws_ses. It also required an update to the :ex_aws_ses library, which entailed a change to how templated emails are passed - that is, it now uses an explicit function.

I made the requisite changes, which pass the tests, and also added a new test to demonstrate passing tags. The templating function inside :ex_aws_ses handles json pre-encoding of the data, so I was also able to remove Jason from the dependencies.

All things considered, the patch is very minor. Let me know what you think. It would be good to see this hit upstream on git

Cheers,

Jarrod

jarrodmoldrich commented 3 years ago

Just seen that you've made the same changes... embarrassing. I'll open a new updated PR

jarrodmoldrich commented 3 years ago

So I've rebased on your latest upstream commits. I've removed the template function in line with yours. It still lives in the history at 1af8256

kalys commented 2 years ago

Fixed in 0.3.0