search

kamaladafrica / axon-cdi

Axon Framework CDI Integration
Apache License 2.0
6 stars 1 forks source link

Initial commit v3.x #3

Closed dcdh closed 7 years ago

dcdh commented 7 years ago

Hello Alessio, Thanks a lot about this project to make axon works under CDI.

I've updated your code to be compliant with version 3.0.5 of axon - I have also updated axon-cdi-quickstart too.

Can you make a review ?

Regards, Damien

zambrovski commented 7 years ago

Hi Damien,

very cool. In your pull request you just let the code work with Axon 3, that is great.

I think many things and concepts have changed in Axon 3, like Confugurer for execution of the entire configuration tasks. In fact I'm also building something similar, but I focus on Axon 3 features (more annotations, no inheritance).

Still, I'm very inistering in the implementation and will examine your PR.

Kind regards,

Simon

kamaladafrica commented 7 years ago

@zambrovski I agree with you, in Axon 3 many concepts changed and, in my opinion, integrating CDI through the Axon Configurer should be the way to go. @dcdh your work is impressive, good job. In the meanwhile axon-cdi move to a Configurer-based integration, this pull request is the best choice.