Closed kamecha closed 1 day ago
[!CAUTION]
Review failed
The pull request is closed.
The recent changes enhance the denops
functionality by introducing an asynchronous method getFile
for downloading files and processing them for image rendering using the sixel graphics protocol. Additionally, a new downloadFile
function has been implemented to facilitate file fetching, and documentation has been updated to guide users on utilizing these features effectively.
Files | Change Summary |
---|---|
denops/traqvim/main.ts | Added async getFile(fileId: unknown) method to download files and process them for sixel rendering. |
denops/traqvim/model.ts | Introduced async downloadFile(fileId: string): Promise<Uint8Array> for fetching files based on file IDs. |
doc/traqvim.jax | Added an FAQ section on displaying images using sixel graphics, including installation steps and usage examples for user guidance. |
Objective | Addressed | Explanation |
---|---|---|
Sixel対応端末での画像表示 (Issue #7) | ✅ | |
メッセージでの画像表示やスタンプ表示をやってみる (Issue #7) | ✅ |
In the denops land where images play,
A rabbit hops by, brightening the day.
With sixel magic, we’ll show our art,
Downloading wonders, a true work of heart.
So let’s celebrate, with joy and glee,
For every file brings new sights to see! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
画像がでか過ぎたりするとその一部しか表示されないので、補完ウィンドウみたいな感じで適切な大きさにするようにしたい
https://github.com/gw31415/denops-sixel-view.vim/pull/1
PR出してみた ワクo(´∇`o)(o´∇`)oワク
sixel用プラグインがちゃんと認識されてるかチェックを入れとく
windows terminalもpreviewだとsixel対応したし、mergeしてドッグフーディングとやらをやってきたい
https://github.com/gw31415/denops-sixel-view.vim
↑を使ってsixelを表示するようにしてみた
本家の方がUint8Arrayを受け付けるようにしたり、色々手を加える必要があるため一旦保留
Close #7
Summary by CodeRabbit
New Features
Bug Fixes