fix #7 added support for private/protected fields

kamikat / moshi-jsonapi

JSON API v1.0 Specification in Moshi.

MIT License

156 stars 34 forks source link

fix #7 added support for private/protected fields #10

Closed mreichelt closed 8 years ago

mreichelt commented 8 years ago

also added unit tests for serialization/deserialization
also covered the case where fields might be inherited from parent classes
also added TestResources to load real .json files (which are easier to read than Java strings with all the quotes)

mreichelt commented 8 years ago

@joachimr please review

coveralls commented 8 years ago

Coverage increased (+0.1%) to 92.659% when pulling 1af3660e10763eb55925605209605e5c3ce27bb4 on mreichelt:fix-7-allow-private-and-protected-fields into fe2e75b047bdd17f412b41a0ef70b6a3d099e5bf on kamikat:master.

JoachimR commented 8 years ago

review done

mreichelt commented 8 years ago

@kamikat I added support for private & protected fields. Hope you like it. :) My colleague @joachimr already gave it a review, too.

coveralls commented 8 years ago

Coverage increased (+0.1%) to 92.659% when pulling 25d6d1275e3317dc8158e788a59f068f0676a874 on mreichelt:fix-7-allow-private-and-protected-fields into fe2e75b047bdd17f412b41a0ef70b6a3d099e5bf on kamikat:master.

kamikat commented 8 years ago

Merged. And version 2.1.0 released.