search

kamilkisiela / apollo-angular

A fully-featured, production ready caching GraphQL client for Angular and every GraphQL server 🎁
https://apollo-angular.com
MIT License
1.5k stars 309 forks source link

Cover batched XHR cancelling with tests #1742

Closed PowerKiKi closed 1 year ago

PowerKiKi commented 2 years ago

Checklist:

This is dependent on https://github.com/apollographql/apollo-client/pull/9248, so it is not strictly specific to apollo-angular, but it seemed important to ensure that this package does indeed allow to cancel XHR even when batching is enabled.

There is no changelog entries, because there not change at all for end-users.

It should only be merged after a new apollo-client is released (and after updating our lock file).

PowerKiKi commented 2 years ago

Now that @apollo/client 3.6.0 has been released, this PR can be reviewed and merged too.

PowerKiKi commented 2 years ago

@kamilkisiela since this is mostly adding new test cases, it should be relatively fast to review. Do you think it could get merged ?

PowerKiKi commented 2 years ago

Rebased.

Because CI pipeline changed after this PR was created it looks like some jobs are still pending. But actually everything that need to pass does indeed pass.

@kamilkisiela would you have an opportunity to review this ?

PowerKiKi commented 1 year ago

@kamilkisiela since you spent a bit of time on this lib recently, maybe you'd have time to review this (rebased) PR ?

kamilkisiela commented 1 year ago

@PowerKiKi do you want to maintain the library? :)

kamilkisiela commented 1 year ago

say Yes and I click "merge" :)

PowerKiKi commented 1 year ago

Yes :smiley:

But I'd like to ask a few you question before if you actually step down from being a maintainer. Such as why did you recently re-introduce ApolloModule ? and why would you step down ?

kamilkisiela commented 1 year ago

@PowerKiKi do you use Slack? If so, are you okay with joining The Guild's #apollo-angular channel? It would be easier to discuss things.

In short, I'm not stepping down, it's just that I'm too busy with other things and this project needs some love. ApolloModule was re-introduced to enable back the lazy loading. Also, using APOLLO_OPTIONS was out of sync with initialization of Apollo service, same for APOLLO_FLAGS.

PowerKiKi commented 1 year ago

I don't usually use slack, but I will if necessary. I can't find the URL for Slack anywhere though....

kamilkisiela commented 1 year ago

I need to invite you, it's not a public slack. Can share your email address with me, over email (to not expose it here)?