search

kamilkisiela / apollo-angular

A fully-featured, production ready caching GraphQL client for Angular and every GraphQL server 🎁
https://apollo-angular.com
MIT License
1.5k stars 309 forks source link

Upgrade to Angular 14 #1803

Closed dlq84 closed 2 years ago

dlq84 commented 2 years ago

This PR upgrades to Angular 14. It does pass yarn test and yarn build locally.

It also includes this PR #1781, closed that one because this replaces it.

dlq84 commented 2 years ago

Ok, It did build correctly, but the "testapp" fails on Angular 14 because it expects the --graphql flag to be a string. But I'm not too familiar with github CI to know if my fix works. Let me know if it works and if it doesn't, suggestions on how to fix it.

dlq84 commented 2 years ago

So looks like if you compile with Angular 14 you can't use it in previous versions: https://github.com/angular/angular/issues/46748#issuecomment-1178817658

Should we just restrict this to Angular 14 or do you want to keep compiling with Angular 13?

dlq84 commented 2 years ago

@cypress/schematic@2.0.0 changed map/file structures, this is now handled.

dlq84 commented 2 years ago

@de-dan Is there anything I need to do to get rid of Angular 12 and 13 tests? Except those and gh-release it looks like it's ready now.

de-dan commented 2 years ago

I don't know unfortunately. I've seen your changes in .github/workflows/main.yml - that should be it. @kamilkisiela could you have a look?

kamilkisiela commented 2 years ago

Thank you

kamilkisiela commented 2 years ago

4.0.0

charlypoly commented 2 years ago

/theguild newsletter