kamilkisiela / apollo-angular

A fully-featured, production ready caching GraphQL client for Angular and every GraphQL server 🎁
https://apollo-angular.com
MIT License
1.5k stars 309 forks source link

Angular 15 #1847

Closed Destreyf closed 1 year ago

Destreyf commented 1 year ago

Describe the bug Currently cannot install apollo-angular inside of an angular 15 repository.

Additional context I recently upgraded my repository to angular 15 and cannot install apollo-angular due to dependency conflict.

kpkingg commented 1 year ago

Hello Me too cannot install apollo-angular v.4.1.1 ( I'm using angular v15.0.0 / node v18.12.1 / npm v8.19.2), apparently is not compatible with angular v15 yet.

rm__v2 % ng add apollo-angular ℹ Using package manager: npm ⚠ Unable to find compatible package. Using 'latest' tag. ⚠ Package has unmet peer dependencies. Adding the package may not succeed.

The package apollo-angular@4.1.1 will be installed and executed. Would you like to proceed? Yes npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: rm--v2@0.0.0 npm ERR! Found: @angular/core@15.0.0 npm ERR! node_modules/@angular/core npm ERR! @angular/core@"^15.0.0" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer @angular/core@"^14.0.0" from apollo-angular@4.1.1 npm ERR! node_modules/apollo-angular npm ERR! apollo-angular@"4.1.1" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution. npm ERR! npm ERR! See /Users/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in: npm ERR! /Users/.npm/_logs/2022-11-19T15_09_05_281Z-debug-0.log ✖ Packages installation failed, see above.

danielzgtg commented 1 year ago

The workaround before it is published is to add the following to package.json:

  },
  "overrides": {
    "apollo-angular": {
      "@angular/core": "^15.0.0"
    }
  }
bendehghan commented 1 year ago

Is anything else holding back publishing this? I would keep the bug open until the publish. That way external people can track it easier. Thank you for the PR.

PowerKiKi commented 1 year ago

The issue is closed automatically when the related PR is merged.

If you need to know whether a certain fix is released either check change log, or better yet check the individual commit to see if it is included in any tag at all.

Nothing is really holding back the release. But only @kamilkisiela can do it. And I guess he's been busy lately

TomONeill commented 1 year ago

@PowerKiKi Thanks for the update.

@kamilkisiela can you push a new release to npm? Maybe add someone else with rights too in times you're busy so people aren't dependant on one person.

antonio-spinelli commented 1 year ago

is it stable? can someone publish it on npm? thanks

marcos-castrillo commented 1 year ago

Thank you for the PR, my team would also like to see it published

SimonCockx commented 1 year ago

We would also love this to be published (@kamilkisiela) . Thanks @PowerKiKi for the PR!

bendehghan commented 1 year ago

Does anyone have an example of using apollo with typescript in an angular project without this package? We're not using any local caching so I think it'd be just safer to go with the typescript directly. I'm looking online bug google keeps pointing to this package when searching for apollo + typescript + angular. I'm looking to remove our dependency on this package since it seems dormant. Thank you and happy new year :)

PowerKiKi commented 1 year ago

"local caching" has nothing to do with Apollo Angular, it comes with Apollo core. Apollo Angular only offer a wrapper for easier use within an Angular project, but it adds no (major) features.

Also Apollo Angular is far from dormant. We are experiencing a small delay in releasing right now, but otherwise the project is alive and kept in sync with both Apollo and Angular regularly. The overall activity is not huge, because precisely this package is "only" a wrapper.

bbroereES commented 1 year ago

We would love to see this published too!

PowerKiKi commented 1 year ago

It was released as https://www.npmjs.com/package/apollo-angular/v/4.2.0