search

kamilkisiela / apollo-angular

A fully-featured, production ready caching GraphQL client for Angular and every GraphQL server 🎁
https://apollo-angular.com
MIT License
1.5k stars 309 forks source link

Angular 17 #2093

Closed PowerKiKi closed 10 months ago

PowerKiKi commented 10 months ago

Fixes #2090

changeset-bot[bot] commented 10 months ago

🦋 Changeset detected

Latest commit: 110a7fd40d67e50e7c901db71925aa4094dee5fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | apollo-angular | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 10 months ago
### 💻 Website Preview The latest changes are available as preview in: [https://8f47fb3a.apollo-angular.pages.dev](https://8f47fb3a.apollo-angular.pages.dev)
rezoled commented 10 months ago

FYI, updating the project to Angular 17 and running it causes tests to break. Here is a PR with the fixed code: https://github.com/kamilkisiela/apollo-angular/pull/2094

github-actions[bot] commented 10 months ago

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets): Package Version Info
apollo-angular 6.0.0-alpha-20231122031041-110a7fd4 npm ↗︎ unpkg ↗︎
PowerKiKi commented 10 months ago

@MerlinMoos, @rezoled, thank you both for your contribution. I see we all worked at the same time on a very similar solution. I am trying to consolidate everything in this PR. Feel free to let me know if you think I forgot something.

PowerKiKi commented 10 months ago

I am having trouble with the error Project target "build" not found., if somebody has an idea...

rezoled commented 10 months ago

Did you try my PR? https://github.com/kamilkisiela/apollo-angular/pull/2094#issuecomment-1809441674 I ran all the tests successfully on my local machine

PowerKiKi commented 10 months ago

Unfortunately your PR did not run successfully for all Angular versions: https://github.com/kamilkisiela/apollo-angular/actions/runs/6849193747

In this PR, I dropped support for Angular 14 , 15 and 16 because of that.

I am considering dropping schematics if those prove too time-consuming to maintain (@kamilkisiela an opinion about that ?)

rezoled commented 10 months ago

I removed angular 14,15,16 support, can you try to run the tests again? I'm not sure why it even failed. Here is the new PR: https://github.com/kamilkisiela/apollo-angular/pull/2103