Closed GoogleCodeExporter closed 8 years ago
Some progress has already been made on this front- now there are no SQL queries
performed in common.php.
Files that still need modification:
admin.php (some)
drydock.php
editpost.php (a lot)
post-common.php
recentpics.php
recentposts.php
thread.php (just a few places)
??? (We'll have to check some of the subfolders as well)
It's okay to have stuff in this version of upgrade_install.php, obviously.
rebuilds.php has already been taken care of, as well as profiles.php.
Original comment by all.sta...@gmail.com
on 9 Dec 2008 at 6:38
recentposts.php no longer has DB logic in it. recentpics.php will have its DB
logic
moved into the new ThornToolsDBI, once we figure out what else to do with that.
Original comment by all.sta...@gmail.com
on 10 Dec 2008 at 7:59
We need to have some sort of formal definition of what a DBI is supposed to
have, and
standardize it between the two.
I'm going to start writing some abstract interfaces for all of the DBI classes.
Original comment by all.sta...@gmail.com
on 10 Dec 2008 at 8:13
Abstract interfaces are done. Still not sure what to do about fetching
pictures.
From now on, all specifications for a particular function will go in the
abstract
interface, instead of copying and pasting the function information comment
header
across DBIs, which could lead to future problems.
Original comment by all.sta...@gmail.com
on 11 Dec 2008 at 7:52
Now only two files have database queries in them:
recentpics.php (because we haven't figured out how to structure the new kind of
queries to that board filtering is possible)
editpost.php (This might be a pain. We'll see I suppose.)
We're going to rework these anyway to a templated version, which is also
convenient.
Original comment by all.sta...@gmail.com
on 12 Dec 2008 at 8:16
These two are taken care of. We might need to change one or two Smarty filters
though (but with the change to getimgs, I do not think that we will need the
extra_info plugin any more- we can just use the new column exif_text and bypass
the
middleman)
Original comment by all.sta...@gmail.com
on 14 Dec 2008 at 12:00
I removed the extra_info plugin, changed the required templates, and changed
quotereply (do we need to include a DBI for this?)
Original comment by all.sta...@gmail.com
on 14 Dec 2008 at 9:02
Well I don't know why this wasnt marked as fixed because it's pretty clear that
all
the db stuff is moved now
Original comment by TaQS...@gmail.com
on 23 Aug 2009 at 9:06
Original issue reported on code.google.com by
all.sta...@gmail.com
on 9 Dec 2008 at 6:32