Plugin for reproducible reduction

stelzch commented 3 months ago

This implements a communicator for reproducible reduction using a binary tree scheme.

Comment on remaining TODOs:

I tried to avoid spelling out the ResultType explicitly, but attempts to factor out a send method with return type auto and specifing the type of _request using declval and decltype were unsuccessful. Any ideas are highly appreciated.
Currently, the reduction does not work on custom datatypes. This is work in progress.
If there are messages on the underlying communicator with the same tag used by reproducible_reduce, the reduce might hang.

lukashuebner commented 3 months ago

See additional comments in Slack

mschimek commented 3 months ago

Is it possible to reduce the number of cores in the tests to prevent the timeout? If not, you have to increase the time-out limit manually (see e.g. grid_alltoall in tests/CMakeLists.txt for the syntax) Furthermore, it seems that some of the tests print something to std::cout. This should be fixed.

mschimek commented 3 months ago

@stelzch can we merge the PR into main or are you still working on it?

stelzch commented 3 months ago

If there are no further requests this can be merged :)

kamping-site / kamping

Plugin for reproducible reduction #705