search

kanari3 / bitrise-step-appcenter-ipa-upload

MIT License
1 stars 2 forks source link

Version 0.0.3 backward compatibility (missing env. variable) #6

Open jakubknejzlik opened 4 years ago

jakubknejzlik commented 4 years ago

Hello guys, this change specifically breaks previous builds: https://github.com/kanari3/bitrise-step-appcenter-ipa-upload/commit/258569bd22707ea0ae56d9a05fcc8c9182a04318#diff-11268f778298d21634cd733e189c62dcR17

Shouldn't be there default value to keep it backward compatible for example?

${APP_CENTER_BUILD_MESSAGE|-bitrise build}

As this is adding feature it should be at least minor version (we are using minor version updates, but we hit this anyway :) ).

kanari3 commented 3 years ago

@jakubknejzlik Thanks for issue. I solved the problem with the following. https://github.com/kanari3/bitrise-step-appcenter-ipa-upload/issues/2#issuecomment-942942276