search

kandanapp / kandan

Kandan is an Open Source Alternative to HipChat
GNU Affero General Public License v3.0
2.71k stars 405 forks source link

Our test suite is not growing. #149

Open jrgifford opened 11 years ago

jrgifford commented 11 years ago

The history of our spec/ directory is basically untouched.

Yes, I know that we're a frontend-heavy app, and are mainly using rails as an API. But, even so, we have been accepting PRs without tests.

So the question I have is basically: Do we care? I think I care, but I haven't done JS testing before. There seems to be a number of resources out there:

Or maybe we should consider doing something like cucumber/acceptance testing?

This is kind of a delicate and sensitive issue for people in the rails community, so I'm open to debate on this.

NARKOZ commented 11 years ago

https://github.com/jfirebaugh/konacha

mjtko commented 11 years ago

I agree that it's important that the frontend does have test coverage, but I have no real concept of how to hook tests into Backbone etc.

If somebody is able to kick off the design/implementation of the test suite, I'd be happy to help out with implementing tests once I have seen some examples and understand and recognise the patterns to use for testing the front-end.

oponder commented 11 years ago

I created a pull request which sets up some front end testing with capybara and poltergeist: https://github.com/kandanapp/kandan/pull/206

Wonder what you guys think of the approach.