search

kanryu / quickviewer

A image/comic viewer application for Windows, Mac and Linux, it can show images very fast
https://kanryu.github.io/quickviewer/
GNU General Public License v3.0
536 stars 63 forks source link

use specific action roles instead of text heuristic roles #86

Closed pazos closed 6 years ago

pazos commented 6 years ago

by default Qt on mac tries to populate the 'native' application menu with - at least - the action for preferences, and the action for quit. It also tries to find the 'about' and 'aboutQt' actions - if any.

Those text heuristics can clash on some circunstances e.g: having 2 or more actions called SettingsSomething - or even worst - having 2 or more actions named with different names but with the same translation string.

This commit replaces the default TextHeuristicMenuRole by specific common actions. (about, quit, preferences, keyboard & mouse preferences..)

preview of the application menu - in spanish.

ba

preview of the help menu - in spanish.

be

also, please consider using the Sparkle framework and winsparkle for providing in-app update capabilities on mac and windows.

I never used winsparkle but sparkle for mac can be easily integrated on qt applications.

kanryu commented 6 years ago

Why is it such a row of menus? What? What?

It seems necessary to think over how to do the notation of the main version of the Mac version over time.

pazos commented 6 years ago

Why is it such a row of menus? What? What? It seems necessary to think over how to do the notation of the main version of the Mac version over time.

Sorry, but I don't understand what you're saying :d