kant2002 / gulp-tsc

gulp.js plugin for compiling TypeScript files
MIT License
16 stars 11 forks source link

Blacklisted, duplicate of gulp-typescript #8

Open ivogabe opened 9 years ago

ivogabe commented 9 years ago

This plugin has been blacklisted in the official gulp plugins repository, with the reason operates directly on file paths. does too much. Besides that, it looks like similar behavior can be achieved with gulp-typescript (which uses the TypeScript compiler api instead of the tsc command). Following the gulp guidelines, can you instead of creating & maintaining your own plugin, consolidate your work into gulp-typescript? Are there features missing in gulp-typescript that are present in gulp-tsc? If so, we can take a look at how these can be implemented in gulp-typescript.

shinnn commented 9 years ago

I described the detailed reason why this plugin should be blacklisted. https://github.com/gulpjs/plugins/pull/125

Are there features missing in gulp-typescript that are present in gulp-tsc?

Yes, but TypeScript plugin shouldn't have those features.

kant2002 commented 9 years ago

That's bad, but I can live with it probably. The reason why I maintain this plugin is that my projects still used them. I doubt that some features present right now that not present in gulp-typescript.

pligor commented 9 years ago

Please solve any people-issues (aka make love not war) with the owner of this repository https://github.com/ivogabe/gulp-typescript Merge the two into a unified (superior) library Thank you!

kant2002 commented 9 years ago

I by no means don't try avoid using gulp-typescript, but to close support on this project, I have to rewrote my projects to use it, and provide some guidance for other users. This is not practical for me right now. For me easier to maintain this repository, then rewrote build scripts for some my older projects later on when I have free time.

BSick7 commented 9 years ago

@ivogabe @kant2002 i have been using this plugin instead of gulp-typescript because gulp-typescript has been taking 39 seconds to build instead of this one taking 2.4 seconds.

ivogabe commented 9 years ago

@BSick7 that's strange, can you log an issue at the gulp-typescript repo with more details? There shouldn't be such a big difference in speed.

ngryman commented 8 years ago

I use gulp-tsc instead of gulp-typescript simply because more up-to-date options are available.

ivogabe commented 8 years ago

@ngryman Which options are you referring to?

ngryman commented 8 years ago

@ivogabe experimentalDecorators.

ivogabe commented 8 years ago

@ngryman You can set that option just like all other options in your gulpfile or tsconfig file with gulp-typescript.

ngryman commented 8 years ago

@ivogabe Ok, will try, you should add it to your readme :)

ivogabe commented 8 years ago

@ngryman Didn't know it was missing, but I've added it!

ngryman commented 8 years ago

@ivogabe :+1:

ivogabe commented 8 years ago

@amcdnl What do you mean exactly? If I'm not mistaken, a basic configuration with gulp-tsc should be working with gulp-typescript by just replacing gulp-tsc with gulp-typescript.

electricessence commented 8 years ago

@ivogabe ... Here's the deal. I would love to switch to gulp-typescript except that it DOES NOT mirror the behavior of tsc.exe. It follows the 'gulp' way and therefore since it's inception has screwed me over. So I end up using both of these. So every time I use gulp-typescript on my source files, (due to differences in how sourcemaps work) I get a different result and I end up flip-flopping code every time I compile one way or another. :|

Other issue I have is when using gulp-typescript, and I need to double compile (declarations first) it wipes them out! gulp-tsc does not give me grief in this way.

ivogabe commented 8 years ago

@electricessence I saw that you opened an issue for the source maps (ivogabe/gulp-typescript#364), can you also open an issue for the second problem you had? gulp-typescript should give the same output as tsc, but its configuration follows the 'gulp' way.

electricessence commented 8 years ago

@ivogabe https://github.com/ivogabe/gulp-typescript/issues/365