karalabe / hid

Gopher Interface Devices (USB HID)
Other
263 stars 131 forks source link

add instructions for cross-compiling #3

Closed toudi closed 7 years ago

toudi commented 7 years ago

@karalabe does it require any changes or is it simply no good ?

karalabe commented 7 years ago

Thanks for this! I've cherry picked your commit onto master https://github.com/karalabe/hid/commit/b6ff5069c39eba4d6760179e03115aa14b57c6c2 but I did simplify and condense it a bit in a followup commit.

The general contents were fine, but it was a bit long and a bit overly descriptive going into the RPI3 details. I think Go programmers are in general familiar with cross compilation using custom C toolkits, so it should be fine to highlight that it's needed without explicitly providing commands that work in a tiny subset of the environments.

PS: Sorry for not merging sooner, this library is a tiny part of go-ethereum and I don't actively keep track of the helper libs unless there's something wrong or an extension is needed.