Implement new area to batch adjust the lyric start/end time. - Githubissues

karaoke-dev / karaoke

Will be the best karaoke system.

http://blog.karaoke.dev

GNU General Public License v3.0

204 stars 16 forks source link

Implement new area to batch adjust the lyric start/end time. #1252

Closed andy840119 closed 3 months ago

andy840119 commented 2 years ago

For the current goal of the karaoke ruleset(V1), we need to let the user to adjust the start/end lyric time easily.

What's the goal of the time editor:

Some of the lyric's end time should be another lyric's start time.
(Maybe optional) Should select range of the lyric and assign the max amount of lyric should display in the screen(for current one, the answer will be always be 2).
Let user able to adjust the time without breaking the time-tag time, means might not let user drag the time directly. Should use the better way to reduce the mistake.

andy840119 commented 2 years ago

Also, another question:

Where to place this editor? Maybe will be better if can place it into main editor, but it's weird to have overlay in here.

andy840119 commented 2 years ago

Maybe lyric timing editor will become part of karaoke editor like this(Reference the rounded background and right side adjust area)

Also, new inspiration:

Lyric should be selectable after tabbed all the time-tags.
Right-side adjust area might show different content if select one, two three or many lyrics(Need to think about the each cases.)

andy840119 commented 2 years ago

Notice that the same editor might appear in the skin editor if able to adjust the karaoke style and base layout.

andy840119 commented 2 years ago

Right-side adjust area if select:

One lyric: adjust start and end time by dragging the item in the right side edit area.
Two lyrics with overlap timing: nothing
Two lyrics with no overlap timing: should have a tool to make one lyric end time become another lyric's start time.

andy840119 commented 2 years ago

Also, should not show the lyric if not has no time. And should show the warning for those lyrics not showing. . Should be better to show the warning if user not finish all the time-tag time. Because we expect user to edit after all step done in the lyric editor.

andy840119 commented 2 years ago

Also, it might be better if able to show the lyric playfield with blueprint.

andy840119 commented 2 years ago

Or make the question simpler Because we cannot adjust the layout in the lyric, so we "Just" need to make sure that only two lyric in the playfield. And should be able to "Preview" it.

andy840119 commented 3 months ago

This issue can be closed because lyric's start/end time is affected by stage. If the classic stage is created, it should be possible to adjust the time.