search

karaoke-dev / karaoke

Will be the best karaoke system.
http://blog.karaoke.dev
GNU General Public License v3.0
204 stars 16 forks source link

Change `xxxEditMode` to better naming #2100

Closed andy840119 closed 1 year ago

andy840119 commented 1 year ago

EditMode is toooo generic. image Should change into other naming, like LanguageEditSection ?

andy840119 commented 1 year ago

maybe RomajiTagEditMode -> RomajiTagEditStep? Because technically, the step to edit the romaji (or other property) is from left to right.

andy840119 commented 1 year ago

image Man it's hard to make the decision 🤔

image [Update] Guess NoteEditStep is better.

andy840119 commented 1 year ago

Renamed.